Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Mar 12, 2025

  • add signals test
  • refactor arg resolver on page to address edge cases

Make consistent with analytics classic:

  • correctly resolve:
  1. (name, null, properties, options, callback)
  2. (name, null, properties)
  3. (name, null, null, options)

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: e67e054

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (cc14e52) to head (e67e054).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
+ Coverage   83.85%   83.86%   +0.01%     
==========================================
  Files         221      221              
  Lines        5872     5877       +5     
  Branches     1344     1344              
==========================================
+ Hits         4924     4929       +5     
  Misses        948      948              
Flag Coverage Δ
browser 92.27% <100.00%> (+0.01%) ⬆️
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@silesky silesky force-pushed the refactor-argument-resolver-to-address-edge-cases branch from 2b35a07 to 96ebb03 Compare March 12, 2025 21:40
@silesky silesky force-pushed the refactor-argument-resolver-to-address-edge-cases branch from 96ebb03 to d1eb93c Compare March 12, 2025 21:43
@silesky silesky force-pushed the refactor-argument-resolver-to-address-edge-cases branch from 0ff4389 to e67e054 Compare March 12, 2025 22:24
@silesky silesky merged commit b538682 into master Mar 13, 2025
8 checks passed
@silesky silesky deleted the refactor-argument-resolver-to-address-edge-cases branch March 13, 2025 05:25
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants